Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support Header and footer spacing in discharge summaries #8439

Closed
wants to merge 0 commits into from
Closed

Adds support Header and footer spacing in discharge summaries #8439

wants to merge 0 commits into from

Conversation

retrogtx
Copy link

@retrogtx retrogtx commented Aug 29, 2024

Proposed Changes

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ X] Request for Peer Reviews
  • Completion of QA

@retrogtx retrogtx requested a review from a team as a code owner August 29, 2024 09:13
Copy link

netlify bot commented Aug 29, 2024

👷 Deploy request for care-egov-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 322818f

Copy link

vercel bot commented Aug 29, 2024

@retrogtx is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use additional packages to achieve this.

We have a reusable PrintPreview component. Adjust the tailwindcss classes or styles in that to achieve this functionality and wrap the treatment summary with that component instead.

Also, changes to discharge summary can be discarded. Discharge summary generations are done by the backend. Needs to be changed there. File a separate issue in the backend repo (https://github.com/ohcnetwork/care) for that.

@retrogtx
Copy link
Author

can you check if this is good enough?

@retrogtx retrogtx requested a review from rithviknishad August 29, 2024 12:42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes performed in this file breaks an existing usage of the Prescription's Print Preview. Keep the PrintPreview's functionality same as before, instead just add the issues requirements to it (header and footer).

And make changes to the TreatmentSummary instead to adapt to use this component instead.

The layout and functionalities present in Prescriptions Print Preview (provided by the Print Preview) component is what's newer and and must be adopted by older components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header and footer spacing in summaries
2 participants