-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed hacks for loading investigations in Consultation Form, updated type definitions #8416
Removed hacks for loading investigations in Consultation Form, updated type definitions #8416
Conversation
@Nithin9585 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause of the issue is that the backend defaults to dict
if not specified.
https://github.com/ohcnetwork/care/blob/develop/care/facility/models/patient_consultation.py#L83
@Nithin9585 ohcnetwork/care#2410 would be solving the root cause. You may undo these changes and instead update the PR to remove the following hack in the consultation form instead: https://github.com/ohcnetwork/care_fe/blob/develop/src/Components/Facility/ConsultationForm.tsx#L410-L412 |
❌ Deploy Preview for care-net failed.
|
LGTM |
@Nithin9585 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
…d type definitions (#8416) --------- Co-authored-by: rithviknishad <[email protected]>
Required Backends
dict
tolist
and remove deprecatedprescriptions
care#2410Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist