Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unknown option for heartbeat rhythm; adds i18n to vitals section #8411

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 8:01am

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3dd3cee
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c841919346080008df310d
😎 Deploy Preview https://deploy-preview-8411--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 23, 2024

CARE    Run #3177

Run Properties:  status check passed Passed #3177  •  git commit 3dd3ceee43: Fixes unknown option for heartbeat rhythm; adds i18n to vitals section
Project CARE
Branch Review rithviknishad/fix/8406-rhythm-unknown
Run status status check passed Passed #3177
Run duration 02m 56s
Commit git commit 3dd3ceee43: Fixes unknown option for heartbeat rhythm; adds i18n to vitals section
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 23, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Aug 23, 2024
@samholics
Copy link

Tested working @nihal467

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8e450ac
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d597f9e9d7480008c2ee85
😎 Deploy Preview https://deploy-preview-8411--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

LGTM

@khavinshankar khavinshankar merged commit d65c6ee into develop Sep 2, 2024
29 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8406-rhythm-unknown branch September 2, 2024 14:07
Copy link

github-actions bot commented Sep 2, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the Unknown option for rhythm in detailed update
4 participants