Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scroll Issue with Pressure Sores Popup #8400

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Aug 22, 2024

Proposed Changes

Screen.Recording.2024-08-22.at.6.10.44.PM.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@gigincg gigincg requested a review from a team as a code owner August 22, 2024 12:42
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:06pm

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 65a9d88
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c745a0f05cac00076e4550
😎 Deploy Preview https://deploy-preview-8400--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The popup now opens far away from the cursor click position.

We could instead attempt to use relative in parent component and absolute or sticky in the Popup's div. This would also eliminate the need of calculations.

Screen.Recording.2024-08-22.at.18.19.49.mov

Copy link

cypress bot commented Aug 22, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit 65a9d88
Started Aug 22, 2024 2:10 PM
Ended Aug 22, 2024 2:13 PM
Duration 02:54 💡
OS Linux Ubuntu -
Browser Chrome 128

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@gigincg
Copy link
Member Author

gigincg commented Aug 22, 2024

@rithviknishad Thanks for the review, redid the calculations a bit, I think it should be fine now! Do check it out once more

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Aug 22, 2024
@khavinshankar khavinshankar merged commit ca56ccc into develop Aug 22, 2024
63 checks passed
@khavinshankar khavinshankar deleted the popup_position_5088 branch August 22, 2024 16:29
Copy link

@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
* Fix Scroll Issue with Pressure Sores Popup

* Improve Computation to anchor next to the click

* remove todo comment from pressure sore component

---------

Co-authored-by: Rithvik Nishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure pop-up not scrolling along with page
4 participants