Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation check for phone number in patient list page #8189 #8394

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Improve validation check for phone number in patient list page #8189 #8394

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d4c4368
Improve validation check for phone number in patient list page #8189
Nithin9585 Aug 22, 2024
36aa19e
Fix issueImprove validation check for phone number in patient list
Nithin9585 Aug 24, 2024
852aac6
Merge branch 'develop' into issues/8189/phone-validation
nihal467 Sep 2, 2024
fd3bc3e
Merge branch 'develop' into issues/8189/phone-validation
nihal467 Sep 3, 2024
74c48a9
Merge branch 'develop' into issues/8189/phone-validation
rithviknishad Sep 30, 2024
367f650
refactor and cleanup validation checks
rithviknishad Sep 30, 2024
a5e0314
make code more readable
rithviknishad Sep 30, 2024
d24df5d
Merge branch 'develop' into issues/8189/phone-validation
rithviknishad Oct 8, 2024
d18046c
remove unnecessary length check
rithviknishad Oct 8, 2024
306c3ab
Merge branch 'develop' into issues/8189/phone-validation
nihal467 Oct 16, 2024
7d9c166
Merge branch 'develop' into issues/8189/phone-validation
nihal467 Oct 17, 2024
f3745cb
update indian landline number regex as per TRAI documentation
rithviknishad Oct 18, 2024
3c072bf
Merge branch 'develop' into issues/8189/phone-validation
khavinshankar Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Components/Patient/ManagePatients.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ export const PatientManager = () => {
qParams.phone_number && updateQuery({ phone_number: null });
return;
}

setPhoneNumberError("Enter a valid number");
};

const setEmergencyPhoneNum = (emergency_phone_number: string) => {
Expand All @@ -141,8 +139,6 @@ export const PatientManager = () => {
updateQuery({ emergency_phone_number: null });
return;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To continue with the error, i.e., 8-digit and 9-digit phone numbers are considered valid. This is because it is validating telephone numbers and other numbers that are more than 10 digits 13 digits. Can I get some suggestions to correct this?

Copy link
Member

@rithviknishad rithviknishad Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to clear the error if we are not setting the error state with a value in the first place right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what about this issue 8 digit and 9 digit numbers are considered as valid because it is validating telephone number also !.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can trigger the search as soon as the number is considered valid. Use the PhoneNumberValidator utility to achieve that.

}

setEmergencyPhoneNumberError("Enter a valid number");
};

const tabValue =
Expand Down
Loading