Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide N/A and null values in event log #8376 #8381

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Hide N/A and null values in event log #8376 #8381

merged 8 commits into from
Aug 22, 2024

Conversation

Nithin9585
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [] Request for Peer Reviews
  • Completion of QA

@Nithin9585 Nithin9585 requested a review from a team as a code owner August 21, 2024 06:38
@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024

@Nithin9585 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 297d22f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c6f71705be5a000806053c
😎 Deploy Preview https://deploy-preview-8381--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Aug 21, 2024
View reviewed changes
src/Components/Facility/Consultations/NeurologicalTables.tsx Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has nothing to do with Event Logs.
You might want to have a look at this file instead: https://github.com/coronasafe/care_fe/blob/develop/src/Components/Facility/ConsultationDetails/Events/GenericEvent.tsx

@rithviknishad rithviknishad added invalid This doesn't seem right changes required labels Aug 21, 2024
@Nithin9585 Nithin9585 mentioned this pull request Aug 21, 2024
Closed
@rithviknishad rithviknishad removed the invalid This doesn't seem right label Aug 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @Nithin9585,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 21, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Aug 22, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a7101ef into ohcnetwork:develop Aug 22, 2024
28 of 30 checks passed
@github-actions GitHub Actions
Copy link

@Nithin9585 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
@Nithin9585 @nihal467
@rithviknishad @UdaySagar-Git
Hide N/A and null values in event log ohcnetwork#8376 (ohcnetwork#8381)
7f51640 
* Hide N/A and null values in event log ohcnetwork#8376

* Hide N/A and null values in GenericEvent component

* Refactor GenericEvent component to improve readability and efficiency

* Revert NeurologicalTables.tsx to previous state

* Resolved conflict in GenericEvent component

---------

Co-authored-by: Mohammed Nihal <[email protected]>
Co-authored-by: Rithvik Nishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker shivankacker approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide N/A and Null values in events log on frontend
5 participants
@Nithin9585 @nihal467 @shivankacker @rithviknishad @khavinshankar