Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to session expired page instead of showing notification #8363

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Navigate to session expired page instead of showing notification

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner August 20, 2024 10:45
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:18am

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fc961f2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c5becfb19d28000806bee2
😎 Deploy Preview https://deploy-preview-8363--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 20, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit fc961f2
Started Aug 21, 2024 10:24 AM
Ended Aug 21, 2024 10:28 AM
Duration 03:34 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@nihal467
Copy link
Member

@rithviknishad can you fix the cypress failure

src/Utils/request/handleResponse.ts Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

LGTM

@khavinshankar khavinshankar merged commit c471332 into develop Sep 3, 2024
63 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/session-expiry branch September 3, 2024 09:33
Copy link

github-actions bot commented Sep 3, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants