Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed React Spring #8306

Closed
wants to merge 1 commit into from
Closed

Removed React Spring #8306

wants to merge 1 commit into from

Conversation

shivankacker
Copy link
Member

Proposed Changes

  • Removes unused dependency react-spring/web

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner August 13, 2024 13:43
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:43pm

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ec261e5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66bb62eb79a29c0008c1aded
😎 Deploy Preview https://deploy-preview-8306--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 13, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit ec261e5
Started Aug 13, 2024 1:48 PM
Ended Aug 13, 2024 1:51 PM
Duration 02:55 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

LGTM, as cypress are passing and random check of the platform looks good

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
Copy link

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@khavinshankar
Copy link
Member

@shivankacker can u resolve the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict needs review tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants