Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort Options functionality of Patient discharge Page #8250

Closed

Conversation

smritidoneria
Copy link

Proposed Changes

Screen.Recording.2024-08-05.at.12.15.58.PM.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [] Request for Peer Reviews
  • Completion of QA

@smritidoneria smritidoneria requested a review from a team as a code owner August 5, 2024 06:48
Copy link

vercel bot commented Aug 5, 2024

@smritidoneria is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

sentry-io bot commented Aug 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/Components/Patient/ManagePatients.tsx

Function Unhandled Issue
PatientManager TypeError: Cannot read properties of undefined (reading 'length') patientList(src/Components/Patien...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 942c9ae
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66b075d437083f0008974aef
😎 Deploy Preview https://deploy-preview-8250--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -894,9 +894,9 @@ export const PatientManager = () => {
onClick={() => advancedFilter.setShow(true)}
/>
<SortDropdownMenu
options={PATIENT_SORT_OPTIONS}
options={DISCHARGED_PATIENT_SORT_OPTIONS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention of the issue was to show discharged patient sort options if the tab selected is discharged. (Which is accessible only for state admins through the ManagePatients component).

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Aug 13, 2024
@github-actions github-actions bot added the stale label Aug 22, 2024
@rithviknishad
Copy link
Member

@smritidoneria Closing this PR as changes in this are invalid and to the associated issue and due to no activity. Feel free to re-open the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the discharge patient list to have consistent sort by and advance filters
2 participants