Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to madatory empty fields #8246

Closed
wants to merge 4 commits into from
Closed

Scroll to madatory empty fields #8246

wants to merge 4 commits into from

Conversation

kushalbhana
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@kushalbhana kushalbhana requested a review from a team as a code owner August 4, 2024 13:20
Copy link

vercel bot commented Aug 4, 2024

@kushalbhana is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1827362
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66b06c28c3d9980008ac2ea8
😎 Deploy Preview https://deploy-preview-8246--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushalbhana

  1. There is already a utility fn. called scrollTo defined. You can simply pass an id value and scroll to the element by invoking the fn.

  2. When there are errors in blood pressure field, it does not auto-scroll to that field.

passed id value in scrollTo function
Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 778714f
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66afc5416300e200080ff8c8

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 4, 2024
Fixed: Used scrollTo() function by passing id
@kushalbhana
Copy link
Contributor Author

Made the changes, please review it.

@rithviknishad
Copy link
Member

@kushalbhana The previous review was not fully solved. Please take a look at the 2nd point.

@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Aug 5, 2024
Made the changes where handled error in blood pressure field
@kushalbhana
Copy link
Contributor Author

#8246 Fixed- Handled error in blood pressure field @rithviknishad

@kushalbhana kushalbhana closed this by deleting the head repository Aug 6, 2024
@rithviknishad
Copy link
Member

@kushalbhana Was this closed by accident?

@kushalbhana
Copy link
Contributor Author

Yes!! let me make the pr again

@kushalbhana kushalbhana mentioned this pull request Aug 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants