Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popup to acknowledge discharge #8211

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 24, 2024 12:57
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:35pm

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 876657b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66a102dd543083000899bd63
😎 Deploy Preview https://deploy-preview-8211--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

Copy link

cypress bot commented Jul 24, 2024

Passing run #2937 ↗︎

0 126 0 0 Flakiness 0

Details:

Add popup to acknowledge discharge
Project: CARE Commit: af5d281135
Status: Passed Duration: 04:03 💡
Started: Jul 24, 2024 1:06 PM Ended: Jul 24, 2024 1:10 PM

Review all test suite changes for PR #8211 ↗︎

@gigincg gigincg merged commit fe63a07 into develop Jul 24, 2024
14 of 19 checks passed
@gigincg gigincg deleted the rithviknishad/feat/acknowledge-popup-2 branch July 24, 2024 13:34
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Copy link

sentry-io bot commented Aug 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RangeError: invalid date submitAction(src/Components/Facility/DischargeM... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caution message on discharge pop-up
3 participants