Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a last online filter for users #8175

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Added a last online filter for users #8175

merged 2 commits into from
Jul 24, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jul 17, 2024 •
edited
Loading

Dependent on ohcnetwork/care#2310

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner July 17, 2024 15:14
@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:34pm

@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2c5ac35
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66a102a290152b000825a3f7
😎 Deploy Preview https://deploy-preview-8175--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jul 17, 2024

Passing run #2895 ↗︎

0 126 0 0 Flakiness 0

Details:

Added a last online filter for users
Project: CARE Commit: 4f44185bb8
Status: Passed Duration: 03:22 💡
Started: Jul 17, 2024 3:19 PM Ended: Jul 17, 2024 3:23 PM

Review all test suite changes for PR #8175 ↗︎

@nihal467
Copy link
Member

@skks1212 attach a screenshot of the change

@nihal467
Copy link
Member

WhatsApp Image 2024-07-23 at 15 26 46_f788e695

@aparnacoronasafe

  1. do we need this many dropdown options for this filters ?
  2. should we change the options as 24 hour, 1 week, 1 months, or number of days seems fine ?

@nihal467 nihal467 added question Further information is requested changes required and removed changes required labels Jul 23, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 23, 2024 •
edited
Loading

@aparnacoronasafe approved the existing UI and PR looks good

@nihal467 nihal467 added tested and removed needs testing question Further information is requested labels Jul 23, 2024
@gigincg gigincg merged commit d1a2dd7 into develop Jul 24, 2024
22 of 27 checks passed
@gigincg gigincg deleted the last-online-filter branch July 24, 2024 13:34
@github-actions GitHub Actions
Copy link

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@gigincg gigincg gigincg approved these changes

Assignees
No one assigned
Labels
needs review tested waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avail the filter to extract users who never logged In
4 participants
@shivankacker @nihal467 @gigincg @rithviknishad