Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvalidStateError in useMSEplayer hook #8000

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Jun 7, 2024

Related to #7999

Adds checks to prevent InvalidStateError in useMSEMediaPlayer hook by ensuring SourceBuffer is not removed before attempting to append buffers.

  • Implements a condition to check if mseSourceBuffer has been marked as removed before calling mseSourceBuffer.appendBuffer(packet) in both pushPacket and readPacket functions.
  • Logs an error message to the console if an attempt is made to append to a removed SourceBuffer, preventing the execution of the appendBuffer method in such cases.

For more details, open the Copilot Workspace session.

Sentry: https://coronasafe-network.sentry.io/issues/5015520076/?project=5183632&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&stream_index=2

@bodhish bodhish requested a review from a team as a code owner June 7, 2024 17:07
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 5:09pm

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 44d7dfe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66633e6932af7400080e30f8
😎 Deploy Preview https://deploy-preview-8000--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish bodhish requested a review from gigincg June 7, 2024 17:08
Copy link

cypress bot commented Jun 7, 2024

Passing run #2725 ↗︎

0 124 0 0 Flakiness 0

Details:

Fix InvalidStateError in useMSEplayer hook
Project: CARE Commit: 44d7dfe01f
Status: Passed Duration: 02:57 💡
Started: Jun 7, 2024 5:12 PM Ended: Jun 7, 2024 5:15 PM

Review all test suite changes for PR #8000 ↗︎

@khavinshankar khavinshankar merged commit 369a38e into develop Jun 14, 2024
68 checks passed
@khavinshankar khavinshankar deleted the bodhish/fix-buffer-error branch June 14, 2024 11:58
Copy link

@bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants