Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ABHA popup UI #7975

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Updated ABHA popup UI #7975

merged 5 commits into from
Jul 9, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jun 5, 2024 •
edited
Loading

Proposed Changes

Screenshot 2024-06-05 at 9 21 51 AM

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner June 5, 2024 03:51
@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 2:45pm

@netlify Netlify
Copy link

netlify bot commented Jun 5, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9017d3b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6684126fceeddf00086fd4c4
😎 Deploy Preview https://deploy-preview-7975--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jun 5, 2024 •
edited
Loading

Passing run #2805 ↗︎

0 126 0 0 Flakiness 0

Details:

Updated ABHA popup UI
Project: CARE Commit: 9017d3b1b1
Status: Passed Duration: 02:55 💡
Started: Jul 2, 2024 2:49 PM Ended: Jul 2, 2024 2:52 PM

Review all test suite changes for PR #7975 ↗︎

@nihal467
Copy link
Member

@skks1212
image

increase the QR code size and keep both sides consistent, ( Between the two drawn lines)

@nihal467
Copy link
Member

@skks1212 make the changes as per the discussion

@nihal467
Copy link
Member

@skks1212
image

as per the discussion, it should be using three rows as existing, don't use 4 rows

@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 26, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 2, 2024

@skks1212 any update on this PR

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

LGTM

@khavinshankar khavinshankar merged commit 7f9a474 into develop Jul 9, 2024
62 checks passed
@khavinshankar khavinshankar deleted the abha-popup-redesign branch July 9, 2024 17:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign ABHA related POP-up
3 participants
@shivankacker @nihal467 @khavinshankar