Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera Feed: Improve watermark and preset sizes in mobile view #7935

Merged
merged 8 commits into from
May 30, 2024
Merged

Camera Feed: Improve watermark and preset sizes in mobile view #7935

merged 8 commits into from
May 30, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 29, 2024 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 9:18am

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1f57b19
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66584449eda1e10009898c32
😎 Deploy Preview https://deploy-preview-7935--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented May 29, 2024 •
edited
Loading

Passing run #2670 ↗︎

0 124 0 0 Flakiness 0

Details:

Camera Feed: Improve watermark and preset sizes in mobile view
Project: CARE Commit: 1f57b19e3c
Status: Passed Duration: 03:36 💡
Started: May 30, 2024 9:23 AM Ended: May 30, 2024 9:26 AM

Review all test suite changes for PR #7935 ↗︎

@rithviknishad rithviknishad marked this pull request as ready for review May 29, 2024 08:39
@rithviknishad rithviknishad requested a review from a team as a code owner May 29, 2024 08:39
@nihal467
Copy link
Member

@aparnacoronasafe can you check this

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit da03963 into develop May 30, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/camera-feed-watermark-and-presets branch May 30, 2024 09:49
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving UI of Camera Feed Watermarks for camera feed
3 participants
@rithviknishad @nihal467 @khavinshankar