Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabled discharge patient admitted to filter #7933

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented May 28, 2024

Dependent on ohcnetwork/care#2204

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner May 28, 2024 16:56
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 1:56pm

@shivankacker shivankacker changed the title reenabled discharge patient admitted to filter Reenabled discharge patient admitted to filter May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6e9c6f6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66a107eb922f8c00088730ab
😎 Deploy Preview https://deploy-preview-7933--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 28, 2024

CARE    Run #3422

Run Properties:  status check failed Failed #3422  •  git commit 6df2932686: Reenabled discharge patient admitted to filter
Project CARE
Branch Review discharge-admitted-to
Run status status check failed Failed #3422
Run duration 07m 02s
Commit git commit 6df2932686: Reenabled discharge patient admitted to filter
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 8
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

Tests for review

Failed  patient_spec/PatientLogUpdate.cy.ts • 5 failed tests • UI-Chrome

View Output

Test Artifacts
Patient Log Update in Normal, Critical and TeleIcu > Create a new Progress log update for a admitted patient and edit it Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new TeleIcu log update for a domicilary care patient Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new Normal Log update for a domicilary care patient and edit it Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new Normal update for a admission patient and verify its reflection in cards Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a Normal Log update to verify MEWS Score Functionality Test Replay Screenshots
Failed  facility_spec/FacilityCreation.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Facility Creation > Create a new facility with multiple bed and doctor capacity Test Replay Screenshots
Failed  facility_spec/FacilityManage.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Facility Manage Functions > Modify bed capacity in Facility detail page Test Replay Screenshots
Failed  facility_spec/FacilityHomepage.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Facility Homepage Function > Verify Facility Export Functionality Test Replay Screenshots

@nihal467
Copy link
Member

nihal467 commented Jun 4, 2024

@skks1212

image

  • when we filter patient with "No bed assigned" , the data is not showing the patient card with no bed history.

image
image

  • when i filter the card with "bed with oxygen support" and "ICU" bed type individually, both are filtering it and showing same data

shivank make sure to run basic QA covering :

  • whether no bed patients are filtered properly, if they were discharged without bed history
  • if a patient have move to multiple bed during the consultation, the filter should only checking his last bed assigned during discharged
  • if a patient have multiple consultation, filter it based on latest consultation

@nihal467
Copy link
Member

nihal467 commented Jun 10, 2024

@skks1212 The filtering works, but it fails when the same patient is readmitted. Currently, the bed history of the latest active consultation is considered, which should not be the case. Instead, the filter should check the last bed of the latest discharged consultation of the facility

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 17, 2024
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@skks1212 can you clear the merge conflict

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 24, 2024
@shivankacker shivankacker force-pushed the discharge-admitted-to branch from 38ebade to c3e1b1a Compare July 24, 2024 13:54
@bodhish
Copy link
Member

bodhish commented Sep 20, 2024

Closing this PR due to lack of recent progress.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 6df2932
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f11f2e31fe800007764118
😎 Deploy Preview https://deploy-preview-7933--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar merged commit a0f5c52 into develop Sep 24, 2024
20 of 25 checks passed
@khavinshankar khavinshankar deleted the discharge-admitted-to branch September 24, 2024 14:43
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up : Admitted to filter in Facility Specific discharge patient page
5 participants