Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added skeleton loader for consent records #7905

Merged
merged 8 commits into from
May 27, 2024
Merged

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented May 27, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner May 27, 2024 06:44
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 4:38pm

Copy link

netlify bot commented May 27, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7c40714
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6654b6e9c8d65f000801db6e
😎 Deploy Preview https://deploy-preview-7905--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 27, 2024

Passing run #2634 ↗︎

0 124 0 0 Flakiness 0

Details:

added skeleton loader for consent records
Project: CARE Commit: 7c4071427b
Status: Passed Duration: 03:26 💡
Started: May 27, 2024 4:43 PM Ended: May 27, 2024 4:46 PM

Review all test suite changes for PR #7905 ↗︎

@nihal467
Copy link
Member

@skks1212
image

its still buddy, with files, it shows no file

Copy link
Member

@nihal467 nihal467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its still buggy

@nihal467
Copy link
Member

  • reset the component once the upload is completed.
  • the upload button is flickering when we click upload button

image

  • bug remains

@shivankacker shivankacker requested a review from nihal467 May 27, 2024 12:35
@nihal467
Copy link
Member

@skks1212
image
image

  • the file is not getting auto-archive
  • when we click the archive button of the file, which should have auto-archived, we can see the archive reason frontend validation is thrown and the reason is auto-filled

Copy link
Member

@nihal467 nihal467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its still buggy, check the above comment

@nihal467
Copy link
Member

nihal467 commented May 27, 2024

image

@skks1212 can you make it responsive

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 828cd50 into develop May 27, 2024
62 of 63 checks passed
@khavinshankar khavinshankar deleted the consent-loader branch May 27, 2024 17:06
Copy link

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loader to the Consent form page No Records Found behavior is not working properly in consent form
4 participants