-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes: Oversized cover image in facility page #7830
fixes: Oversized cover image in facility page #7830
Conversation
@Aryanshu919 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LGTM |
@@ -121,7 +121,7 @@ const CoverImageEditModal = ({ | |||
Success({ msg: "Cover image updated." }); | |||
} else { | |||
Notification.Error({ | |||
msg: "Something went wrong!", | |||
msg: "Oops! Facility cover image is too large. Please use a smaller size image.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be other possibilities where this API can error out i.e., eg: when an SVG file is uploaded, the API errors out, but still file too large message would be shown.
For the issue #7661, make a backend fix where the respective error message is sent based on the actual issue and then show the error message send from the backend here
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @coronasafe/care-frontend-maintainers, This PR has been automatically closed due to inactivity. Thank you for your contributions. Feel free to re-open the PR. |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
[ ] Add specs that demonstrate or test a new feature.
Update [product documentation] (https://docs.coronasafe.network/coronasafe-care-documentation/architecture/architecture-and-layering-of-care).
Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA