Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR code error notification #7726

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Conversation

AshrafMd-1
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner April 27, 2024 17:44
Copy link

vercel bot commented Apr 27, 2024

@AshrafMd-1 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 519fadc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66575a25440af80007f61c00
😎 Deploy Preview https://deploy-preview-7726--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

AshrafMd-1 commented May 1, 2024

@khavinshankar is this okay?

i have combined the asset not found to invalid qr

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

@AshrafMd-1
image

  • something went wrong error is still shown along with the invalid QR code
  • When a staff user scans a valid QR code, but they do not having access to it, due to no access to the asset. So, throwing an "Invalid QR code" error won't make sense, it would be better in these scenerio's to throw a "You don't have permission to access this asset" notification, which will be more proper.

@AshrafMd-1
Copy link
Contributor Author

@nihal467 can you check once

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024

LGTM

@khavinshankar khavinshankar merged commit 5dfced0 into ohcnetwork:develop Jun 5, 2024
28 of 30 checks passed
Copy link

github-actions bot commented Jun 5, 2024

@AshrafMd-1 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify QR code error notification
4 participants