Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Modified Notification related to Patient Log update successfully #7645

Merged
merged 16 commits into from
May 7, 2024
Merged

[FIXED] Modified Notification related to Patient Log update successfully #7645

merged 16 commits into from
May 7, 2024

Conversation

r-nikhilkumar
Copy link
Contributor

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@r-nikhilkumar r-nikhilkumar requested a review from a team as a code owner April 17, 2024 10:55
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024

@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d81a97f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6639e03afc74bc0008694fb7
😎 Deploy Preview https://deploy-preview-7645--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Apr 21, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor suggestions

src/Components/Patient/DailyRounds.tsx Outdated Show resolved Hide resolved
src/Components/Patient/DailyRounds.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@r-nikhilkumar can you please make the requested changes ASAP

@r-nikhilkumar
Copy link
Contributor Author

r-nikhilkumar commented Apr 24, 2024 •
edited
Loading

@nihal467 okay

@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad done, now you can finalize it

rithviknishad
rithviknishad reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithviknishad
Copy link
Member

@r-nikhilkumar lint checks and cypress tests failing

@rithviknishad rithviknishad requested a review from Ashesh3 April 25, 2024 13:33
@r-nikhilkumar
Copy link
Contributor Author

r-nikhilkumar commented Apr 25, 2024 •
edited
Loading

@rithviknishad okay I'm resolving cypress test, lint is done

@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad why this error comming in cypress? this is something related to cy.contains(), can you plz guide
image

@rithviknishad
Copy link
Member

why this error comming in cypress? this is something related to cy.contains(), can you plz guide

The cypress test needs to be modified. Notification message is being verified in cypress. So the updated notification message needs to be used in cypress test.

@rithviknishad rithviknishad added the cypress failed pull request with cypress test failure label Apr 26, 2024
@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad all test passed, now you can finalize this PR

@rithviknishad rithviknishad added needs testing and removed changes required cypress failed pull request with cypress test failure labels Apr 26, 2024
@rithviknishad rithviknishad requested a review from nihal467 April 26, 2024 05:20
@nihal467
Copy link
Member

@r-nikhilkumar
image

  • When we create a critical care log update, it is shown as a "Ventilator" log update created successfully, replace the ventilator with "Critical Care" in the notification

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

LGTM

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

LGTM

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

LGTM

@khavinshankar khavinshankar merged commit d5d9ee9 into ohcnetwork:develop May 7, 2024
28 of 30 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

@r-nikhilkumar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@r-nikhilkumar r-nikhilkumar deleted the Fixes#7619_Modify_Notification_related_to_Patient_Log_update branch May 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihal467 nihal467 nihal467 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the Notification related to Patient Log update
5 participants
@r-nikhilkumar @nihal467 @rithviknishad @Ashesh3 @khavinshankar