Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Improved the change password handling in profile edit page #7639

Conversation

r-nikhilkumar
Copy link
Contributor

@r-nikhilkumar r-nikhilkumar commented Apr 16, 2024

  • Fixes Improve the change password handling in profile edit page #7605

  • password change input box on the profile update page should have the same condition check as the new user creation page✅
    image
    image
    image
    image

  • Show the specific notification only " the old password - wrong password entered. Please check your password "✅
    image

  • add a validation for the new password column checking the current password inputted data and new password column are not having the same text✅
    image

  • Something extra done for making it more robust, I'm showing notification if new password criteria doesn't match while clicking "change password"
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@r-nikhilkumar r-nikhilkumar requested a review from a team as a code owner April 16, 2024 19:29
Copy link

vercel bot commented Apr 16, 2024

@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 72fd3c2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6643ec6c05343c00089d6601
😎 Deploy Preview https://deploy-preview-7639--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes

src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad I made all the changes, now you can finalize it

@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad I solved it... now you can review

@nihal467
Copy link
Member

@r-nikhilkumar
image

  • Once you click the "edit profile" button, the condition for a new password is always present there. It should only be shown when the user clicks on the "new password" column to input the data.

image

  • As per the issue, it is expected to behave similarly to the new user creation form. But in your PR, when the condition passes, they disappear. It shouldn't be the case; it should turn the condition to green.

Note: understand the existing behavior in the new user creation form password input column then replicate that behavior in the edit profile page

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

LGTM

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:06am

@nihal467
Copy link
Member

LGTM

src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit 3180682 into ohcnetwork:develop May 14, 2024
26 of 29 checks passed
Copy link

@r-nikhilkumar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@r-nikhilkumar r-nikhilkumar deleted the Fixes#7605_Improve_change_password_handling branch May 15, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the change password handling in profile edit page
6 participants