-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] Improved the change password handling in profile edit page #7639
[FIXED] Improved the change password handling in profile edit page #7639
Conversation
@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor changes
…/github.com/r-nikhilkumar/care_fe into Fixes#7605_Improve_change_password_handling
Co-authored-by: Rithvik Nishad <[email protected]>
@rithviknishad I made all the changes, now you can finalize it |
@rithviknishad I solved it... now you can review |
Note: understand the existing behavior in the new user creation form password input column then replicate that behavior in the edit profile page |
LGTM |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM |
@r-nikhilkumar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Fixes Improve the change password handling in profile edit page #7605
password change input box on the profile update page should have the same condition check as the new user creation page✅
Show the specific notification only " the old password - wrong password entered. Please check your password "✅
add a validation for the new password column checking the current password inputted data and new password column are not having the same text✅
Something extra done for making it more robust, I'm showing notification if new password criteria doesn't match while clicking "change password"
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers