Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset qr scan #7617

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix asset qr scan #7617

merged 1 commit into from
Apr 15, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 15, 2024

Fixes: #7571

This pull request fixes the asset QR scan functionality by updating the path parameter in the checkValidAssetId function from id to external_id to match the API endpoint.

@Ashesh3 Ashesh3 requested a review from a team as a code owner April 15, 2024 17:56
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:58pm

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 02a86a9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/661d6a6d0ad6f80009abbec7
😎 Deploy Preview https://deploy-preview-7617--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

Copy link

cypress bot commented Apr 15, 2024

Passing run #2374 ↗︎

0 119 0 0 Flakiness 0

Details:

Fix asset qr scan
Project: CARE Commit: 02a86a93e6
Status: Passed Duration: 03:43 💡
Started: Apr 15, 2024 6:02 PM Ended: Apr 15, 2024 6:05 PM

Review all test suite changes for PR #7617 ↗︎

@khavinshankar khavinshankar merged commit 6613db9 into develop Apr 15, 2024
68 of 69 checks passed
@khavinshankar khavinshankar deleted the fix-asset-qr-scan branch April 15, 2024 18:10
Copy link

@Ashesh3 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Scan The QR Code in Asset Module
3 participants