Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Medicine Prescription Log Summary Section #7584

Merged
merged 16 commits into from
May 28, 2024

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Apr 11, 2024

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner April 11, 2024 10:16
Copy link

vercel bot commented Apr 11, 2024

@Pranshu1902 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8948eaa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/665587120506860008161987
😎 Deploy Preview https://deploy-preview-7584--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

image

@Pranshu1902 the dosage is shown twice in the frontend

image

  • when i discontinue a prescription and add the same medicine in prn prescription, the following things are not understandable from this summary .
  1. when is the medicine discontinued
  2. whether its a PRN prescription or a Prescription

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Apr 29, 2024

@nihal467 Updated view:
image

@nihal467
Copy link
Member

nihal467 commented Apr 29, 2024

@Pranshu1902 its still not mentioning its PRN or prescription

@nihal467 nihal467 added question Further information is requested changes required and removed question Further information is requested needs testing labels Apr 29, 2024
@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@Pranshu1902

image
image

  • failed the test , follow the below step to replicate it :

Step 1 : Add a dolo medicine with prescription
step 2 : Change the medicine to titrated dosage
step 3 : Discontinue the medicine
Step 4 : Add the same medicine in PRN Prescription

the medicine summary is missing the discontinue in the timeline

  • when there is no summary, add a text in the bottom "no medicine summary" with white padding similar to the card we show when there is no consultation

Note: Please conduct a full QA of your PR, before marking it again for testing

@nihal467
Copy link
Member

@Pranshu1902
image

  • For PRN prescription and prescription, the regular and PRN should be shown in the prescription type, not in the dosage type
  • replace base dosage as Dosage
  • in titrated dosage replace base dosage as start dosage

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 23, 2024
@Pranshu1902
Copy link
Contributor Author

@nihal467 done
Updated view:
image

@nihal467
Copy link
Member

LGTM

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We could switch to rendering this from events instead in an upcoming PR.

@khavinshankar khavinshankar merged commit 8c311c4 into ohcnetwork:develop May 28, 2024
28 of 31 checks passed
Copy link

@Pranshu1902 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prescription- Log of change
4 participants