Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the scroll issue in Shifting #7491

Closed
wants to merge 3 commits into from

Conversation

dwip708
Copy link

@dwip708 dwip708 commented Mar 28, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@dwip708 dwip708 requested a review from a team as a code owner March 28, 2024 19:58
Copy link

vercel bot commented Mar 28, 2024

Someone is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 24550c9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/660d278277c4810007704541
😎 Deploy Preview https://deploy-preview-7491--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dwip708 dwip708 changed the title Scroll2 Solving the scroll issue in Shifting Mar 28, 2024
isOver && "cursor-move"
)}
style={{ minHeight: `${containerHeight + 100}px` }}
style={{ overflowY: "scroll" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tailwindcss classes instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tailwindcss classes instead

Okk I'll do that.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 11, 2024
Copy link

👋 Hi, @dwip708,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed stale labels Apr 15, 2024
@nihal467
Copy link
Member

@dwip708 what is the status on this PR

@dwip708
Copy link
Author

dwip708 commented Apr 24, 2024

@dwip708 what is the status on this PR

As I said the main scroll issue is fixed but there is a pagination issue, and as a result only 14 records at max is shown under each card in shifting. I am working on that and will solve it by this weekend.

@nihal467
Copy link
Member

@dwip708 closing this PR and unassigning you from this issue due to inactivity, feel free to reopen the same if you are still working on it

@nihal467 nihal467 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll issue in shifting in facilities.
3 participants