redesigned createAsset modal and fixed css overflow issue #7475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MjStar24 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Mar 27, 2024
There was a problem hiding this comment.
- Why are changes to CNS here?
- Also the newly created component is not being used anywhere... Did you forget to push some changes?
- Let's not create an entirely new component if we are simply moving it to the top, we could just pass a prop to the existing reusable component itself. The select button can remain as where it was before itself, the new UI doesn't seem to look good.
|
Thank you, @rithviknishad, for your suggestion. At the moment, I'm pushing the CSS fix and simultaneously working on developing a new UI from scratch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes