Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform type checks during build and fix all errors #7469

Merged
merged 22 commits into from
Apr 2, 2024
Merged

Perform type checks during build and fix all errors #7469

merged 22 commits into from
Apr 2, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 25, 2024 •
edited
Loading

Proposed Changes

Fixed 217 errors

Before

image

After

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 10:33am

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 249f27f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/660bdede30ed8d000845068c
😎 Deploy Preview https://deploy-preview-7469--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 6a20e82
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/6607e54d30d3ba000858375f

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Mar 25, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 27, 2024
@rithviknishad rithviknishad added Major Code Change This Tag represent PR, which will be causing major Code change in the platform P2 and removed work-in-progress Deploy-Failed Deplyment is not showing preview labels Mar 27, 2024
@rithviknishad rithviknishad changed the title Fail build if typescript errors are present Perform type checks during build and fix all errors Mar 27, 2024
This was referenced Apr 1, 2024
Merged
Closed
@nihal467 nihal467 added urgent P1 breaking issue or vital feature and removed P2 labels Apr 1, 2024
@rithviknishad rithviknishad force-pushed the fail-build-on-ts-error branch from 9421343 to 36f41e0 Compare April 2, 2024 04:20
@nihal467
Copy link
Member

nihal467 commented Apr 2, 2024

lgtm

@khavinshankar khavinshankar merged commit fe6e616 into develop Apr 2, 2024
62 of 64 checks passed
@khavinshankar khavinshankar deleted the fail-build-on-ts-error branch April 2, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@rithviknishad rithviknishad mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@sainak sainak Awaiting requested review from sainak

Assignees
No one assigned
Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform needs review P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
4 participants
@rithviknishad @nihal467 @Ashesh3 @khavinshankar