Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added validation for doctor experience input. #7408

Conversation

Spiral-Memory
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA
Solution.mp4

@Spiral-Memory Spiral-Memory requested a review from a team as a code owner March 13, 2024 08:43
Copy link

vercel bot commented Mar 13, 2024

@Spiral-Memory is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4ae7734
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65f96db60b01f70008050c8a
😎 Deploy Preview https://deploy-preview-7408--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Spiral-Memory Spiral-Memory force-pushed the issues/7407/doctor-exp-validation branch from 76124c8 to 0e2d8c0 Compare March 13, 2024 08:51
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
suggested changes applied

Co-authored-by: Ashesh <[email protected]>
@Spiral-Memory Spiral-Memory requested a review from Ashesh3 March 13, 2024 13:03
@Spiral-Memory
Copy link
Contributor Author

Thank you so much for approving the changes. Sorry if I'm asking something irrelevant; I'm new to this repository. May I know how long testing usually takes? @Ashesh3 @rithviknishad

@Ashesh3
Copy link
Member

Ashesh3 commented Mar 17, 2024

Thank you so much for approving the changes. Sorry if I'm asking something irrelevant; I'm new to this repository. May I know how long testing usually takes? @Ashesh3 @rithviknishad

The PRs approved are usually tested within the upcoming week by @nihal467

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Mar 19, 2024
@khavinshankar khavinshankar merged commit b70c853 into ohcnetwork:develop Mar 19, 2024
34 of 35 checks passed
Copy link

@Spiral-Memory Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No validation when doctor experience input is less than 0.
5 participants