fix: Removed unnecessary rendering of microphone permission warning info. #7404

Spiral-Memory · 2024-03-13T07:17:07Z

Proposed Changes

Fixes [BUG]: Unnecessary rendering Mic Permission warning even if mic permission is enabled #7403
It assumes that mic permission is enabled at first.
Added a state to indicate if Mic Permission is enabled.
Based on this state, the warning is rendered.
If permission is not given and the requestRecorder() function throws an error, then we set the state accordingly.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate the bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prepare a screenshot or demo video for the changelog entry, and attach it to the issue.
Request Peer Reviews
Completion of QA

2024-03-13.12-44-13.mp4

vercel · 2024-03-13T07:17:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 7:41am

netlify · 2024-03-13T07:17:25Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`96b6f1b`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/6613c7ea503e340008a0a0eb
😎 Deploy Preview	https://deploy-preview-7404--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-03-13T07:41:34Z

❌ Deploy Preview for care-net failed.

Name	Link
🔨 Latest commit	`7766f35`
🔍 Latest deploy log	https://app.netlify.com/sites/care-net/deploys/660d1d62f518ae00090421e8

vercel · 2024-03-13T07:48:28Z

@Spiral-Memory is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Spiral-Memory · 2024-03-13T07:55:17Z

@rithviknishad , please take a look at this PR. In the CodeClimate test, it is showing that a type definition should be included, but the file I changed is a JavaScript file. If I add a type definition, it will likely result in an error. Kindly review this PR, investigate this issue, and let me know. Thanks.

Spiral-Memory · 2024-03-17T19:53:10Z

Hey @rithviknishad Could you please look into this once ?

nihal467 · 2024-03-19T13:37:44Z

Spiral-Memory · 2024-03-19T13:41:20Z

Could you please explain a little, like what's the problem ?

When permission is not there.. that warming will be shown otherwise it's not. Please refer to the video on how i intended it to be.

If you require any change, please let me know !

rithviknishad · 2024-03-19T13:58:55Z

Hey @Spiral-Memory

Let us just confirm that doing this is okay as IIRC this was kept intentionally, don't remember the reason.

Spiral-Memory · 2024-03-19T14:03:01Z

Hey @Spiral-Memory

Let us just confirm that doing this is okay as IIRC this was kept intentionally, don't remember the reason.

Sure @rithviknishad !

gigincg · 2024-03-20T15:37:47Z

@Spiral-Memory @nihal467 @rithviknishad

Following is the expected Behaviour:

Warning as span :

Shown when Permission is not granted
Hidden when Permission is already granted

Warning as notification:

Shown when Permission is not granted & User clicks on Record button

rithviknishad

LGTM, just some minor suggestions

src/Components/Patient/FileUpload.tsx

rithviknishad · 2024-04-03T08:46:28Z

Also fix the lint errors

Suggested changes applied 1 Co-authored-by: Rithvik Nishad <[email protected]>

Suggested changes applied 2 Co-authored-by: Rithvik Nishad <[email protected]>

Suggested changes applied 3 Co-authored-by: Rithvik Nishad <[email protected]>

…n-warning

nihal467 · 2024-04-08T11:19:43Z

lgtm

github-actions · 2024-04-09T09:17:29Z

@Spiral-Memory Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Spiral-Memory requested a review from a team as a code owner March 13, 2024 07:17

vercel bot temporarily deployed to Preview March 13, 2024 07:17 Inactive

Spiral-Memory changed the title ~~fixed unnecessary placement of mic permission info~~ fix: Removed unnecessary rendering of microphone permission warning info. Mar 13, 2024

vercel bot temporarily deployed to Preview March 13, 2024 07:35 Inactive

vercel bot temporarily deployed to Preview March 13, 2024 07:41 Inactive

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Mar 13, 2024

Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 11e3686 to dd279b5 Compare March 13, 2024 07:42

Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 202d30b to dd279b5 Compare March 13, 2024 07:51

Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from dd279b5 to ff96f59 Compare March 13, 2024 08:31

rithviknishad added needs testing needs review and removed Deploy-Failed Deplyment is not showing preview labels Mar 13, 2024

rithviknishad requested review from Ashesh3 and rithviknishad March 13, 2024 11:01

Ashesh3 approved these changes Mar 13, 2024

View reviewed changes

rithviknishad approved these changes Mar 18, 2024

View reviewed changes

rithviknishad added reviewed reviewed by a core member and removed needs review labels Mar 18, 2024

nihal467 added the discussion required label Mar 19, 2024

nihal467 added needs review and removed reviewed reviewed by a core member labels Apr 3, 2024

rithviknishad reviewed Apr 3, 2024

View reviewed changes

src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved

src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved

src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved

rithviknishad added changes required and removed needs testing labels Apr 3, 2024

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 3, 2024

Ashesh3 approved these changes Apr 3, 2024

View reviewed changes

Spiral-Memory and others added 8 commits April 3, 2024 15:02

fixed unnecessary placement of mic permission info

4c73340

added type void

06014c2

mic warning to render when mic permission is not enabled

3a8fcf5

fixed auto mic permission popup

064cd08

Update src/Components/Patient/FileUpload.tsx

a63f7ba

Suggested changes applied 1 Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Patient/FileUpload.tsx

fb0a104

Suggested changes applied 2 Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Patient/FileUpload.tsx

99ef687

Suggested changes applied 3 Co-authored-by: Rithvik Nishad <[email protected]>

fixed lint errors

3b436ec

Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 88b4fdc to 3b436ec Compare April 3, 2024 09:32

rithviknishad added needs testing and removed changes required Deploy-Failed Deplyment is not showing preview needs review labels Apr 3, 2024

rithviknishad approved these changes Apr 3, 2024

View reviewed changes

Merge branch 'develop' into issues/7403/fixed-rendering-mic-permissio…

96b6f1b

…n-warning

nihal467 added tested cypress passed and removed needs testing labels Apr 8, 2024

khavinshankar approved these changes Apr 9, 2024

View reviewed changes

khavinshankar merged commit d615772 into ohcnetwork:develop Apr 9, 2024
33 of 35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Removed unnecessary rendering of microphone permission warning info. #7404

fix: Removed unnecessary rendering of microphone permission warning info. #7404

Spiral-Memory commented Mar 13, 2024

vercel bot commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading

vercel bot commented Mar 13, 2024

Spiral-Memory commented Mar 13, 2024

Spiral-Memory commented Mar 17, 2024

nihal467 commented Mar 19, 2024

Spiral-Memory commented Mar 19, 2024

rithviknishad commented Mar 19, 2024

Spiral-Memory commented Mar 19, 2024

gigincg commented Mar 20, 2024

rithviknishad left a comment

rithviknishad commented Apr 3, 2024

nihal467 commented Apr 8, 2024

github-actions bot commented Apr 9, 2024

fix: Removed unnecessary rendering of microphone permission warning info. #7404

fix: Removed unnecessary rendering of microphone permission warning info. #7404

Conversation

Spiral-Memory commented Mar 13, 2024

Proposed Changes

Merge Checklist

vercel bot commented Mar 13, 2024 • edited Loading

netlify bot commented Mar 13, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

netlify bot commented Mar 13, 2024 • edited Loading

❌ Deploy Preview for care-net failed.

vercel bot commented Mar 13, 2024

Spiral-Memory commented Mar 13, 2024

Spiral-Memory commented Mar 17, 2024

nihal467 commented Mar 19, 2024

Spiral-Memory commented Mar 19, 2024

rithviknishad commented Mar 19, 2024

Spiral-Memory commented Mar 19, 2024

gigincg commented Mar 20, 2024

rithviknishad left a comment

Choose a reason for hiding this comment

rithviknishad commented Apr 3, 2024

nihal467 commented Apr 8, 2024

github-actions bot commented Apr 9, 2024

vercel bot commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading