Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Events(Beta) improvement #7345

Merged
merged 5 commits into from
Apr 3, 2024
Merged

fix: Events(Beta) improvement #7345

merged 5 commits into from
Apr 3, 2024

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Mar 5, 2024 •
edited
Loading

Bug Fix

Proposed Changes

  • Fixes Events (Beta) improvement #7286
  • Clubs the critical log update
  • Adds Virtual Nursing Assistant for the event reads incase of automated event
  • Adds No change text when all the event values are N/A

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 3:52pm

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3e260a9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/660d11cab365490008bb6dee
😎 Deploy Preview https://deploy-preview-7345--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aeswibon
Copy link
Member Author

aeswibon commented Mar 5, 2024

Will change the status once @aparnacoronasafe replies on my comment #7286 (comment)

@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 13, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024

@aeswibon is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@aeswibon aeswibon marked this pull request as ready for review March 25, 2024 10:45
@aeswibon aeswibon requested a review from a team as a code owner March 25, 2024 10:45
@nihal467
Copy link
Member

nihal467 commented Apr 3, 2024

LGTM

@khavinshankar khavinshankar merged commit f54907f into ohcnetwork:develop Apr 3, 2024
33 of 35 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@aeswibon Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@aeswibon aeswibon deleted the issue#7286 branch April 3, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events (Beta) improvement
4 participants
@aeswibon @nihal467 @Ashesh3 @khavinshankar