Add Patient Filter for Review Missed #7328
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
| @@ -128,6 +128,7 @@ | |||
| "autoprefixer": "^10.4.14", | |||
| "cypress": "^13.5.0", | |||
| "cypress-localstorage-commands": "^2.2.3", | |||
| "dotenv": "^16.4.5", | |||
There was a problem hiding this comment.
Actually, I don't know why using env variables wasn't working in vite.config.mts, when I used "import 'dotenv/config'", it worked. That's the reason.
There was a problem hiding this comment.
that was onw of the reasons why I was unable to connect to the local care backend.
There was a problem hiding this comment.
You could also connect to your local backend using:
CARE_API=https://127.0.0.1:8000/ bun run dev
There was a problem hiding this comment.
Also, after removing dotenv, when I am using process.env.CARE_API, in vite.config.mts, its not working, but working when I am explicitly mentioning https://127.0.0.1:9000/.
There was a problem hiding this comment.
CARE_API=127.0.0.1:9000 bun run dev I added the above line in my .env, but unable to connect to the local backend which is running at http://localhost:9000.
You shouldn't add that to the .env
Instead use that to run in the terminal directly.
There was a problem hiding this comment.
OK, if that's the thing, will try to do it.
There was a problem hiding this comment.
Hey, I have pushed some changes, could you please review them and suggest if any modification is required.
There was a problem hiding this comment.
Also all the tests are now passing successfully.
|
👋 Hi, @jainvedant392, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
Hey @rithviknishad, friendly reminder. |
|
@jainvedant392 ensure checks are passing. Cypress tests and Lint checks are failing. |
Yeah I will check for that. Can you help me on how to ensure these checks are running successfully? |
|
Seems like all checks are passing - LGTM |
|
Hey @rithviknishad, I have written the test for this filter in the backend PR. |
|
@rithviknishad is it good for testing |
|
LGTM |
nihal467
added
tested
reviewed
|
@jainvedant392 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist