Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange tabs in patient dashboard #7320

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Rearrange tabs in patient dashboard #7320

merged 3 commits into from
Mar 5, 2024

Conversation

AnkurPrabhu
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AnkurPrabhu AnkurPrabhu requested a review from a team as a code owner March 1, 2024 19:21
@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 8:30pm

@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9558867
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e62f360450500008fdb0eb
😎 Deploy Preview https://deploy-preview-7320--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnkurPrabhu
Copy link
Contributor Author

@rithviknishad are these test fails due to my change ?

@rithviknishad
Copy link
Member

Nope @AnkurPrabhu

cc: @nihal467

rithviknishad
rithviknishad reviewed Mar 2, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, are the id attribute used anywhere?

@AnkurPrabhu
Copy link
Contributor Author

AnkurPrabhu commented Mar 2, 2024 •
edited
Loading

Correct me if I'm wrong, are the id attribute used anywhere?

Nope was not able to find

@rithviknishad
Copy link
Member

Correct me if I'm wrong, are the id attribute used anywhere?

Nope was not able to find

Let's drop the id too then 😄

@AnkurPrabhu
Copy link
Contributor Author

in ConsultationDetails/index.tsx:423 CONSULTATION_TABS is being mapped there we might need ids ?

@rithviknishad
Copy link
Member

Why is id required there? What purpose/requirement does it satisfy?

@AnkurPrabhu
Copy link
Contributor Author

Why is id required there? What purpose/requirement does it satisfy?

as in as far as i know its good to have ids while mapping it in the front end also CONSULTATION_TABS is of type Array so id is a compulsory field so what do you think should we remove it ? thoughts @rithviknishad ?

@rithviknishad
Copy link
Member

as in as far as i know its good to have ids while mapping it in the front end also CONSULTATION_TABS is of type Array so id is a compulsory field so what do you think should we remove it ? thoughts @rithviknishad ?

It doesn't serve any purpose. It's purely a front-end and thing and has nothing to do with backend. Let's drop ID, it's also not being referenced anywhere else. Also you can drop the type Array<OptionsType> for CONSULTATION_TABS and simply do as const which should take care of the type safety.

@AnkurPrabhu AnkurPrabhu force-pushed the rearrange-tabs-in-patient-dashboard branch from d0378ae to 9558867 Compare March 4, 2024 20:29
@AnkurPrabhu
Copy link
Contributor Author

as in as far as i know its good to have ids while mapping it in the front end also CONSULTATION_TABS is of type Array so id is a compulsory field so what do you think should we remove it ? thoughts @rithviknishad ?

It doesn't serve any purpose. It's purely a front-end and thing and has nothing to do with backend. Let's drop ID, it's also not being referenced anywhere else. Also you can drop the type Array<OptionsType> for CONSULTATION_TABS and simply do as const which should take care of the type safety.

changes are done ptal

@nihal467
Copy link
Member

nihal467 commented Mar 5, 2024

LGTM

@khavinshankar khavinshankar merged commit ae58e87 into ohcnetwork:develop Mar 5, 2024
36 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

@AnkurPrabhu Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
cypress passed reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-arrange tabs in patient dashboard
5 participants
@AnkurPrabhu @rithviknishad @nihal467 @Ashesh3 @khavinshankar