Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing path param error in update asset bed request #7313

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fixes missing path param error in update asset bed request #7313

merged 1 commit into from
Feb 29, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Fixes missing path param error in update asset bed request

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner February 29, 2024 11:40
@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 11:41am

@rithviknishad rithviknishad added urgent needs testing needs review P1 breaking issue or vital feature labels Feb 29, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 35acdcd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e06d394b0f720007500b9e
😎 Deploy Preview https://deploy-preview-7313--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Feb 29, 2024
@cypress Cypress
Copy link

cypress bot commented Feb 29, 2024

Passing run #2193 ↗︎

0 111 0 0 Flakiness 0

Details:

Fixes missing path param error in update asset bed request
Project: CARE Commit: 35acdcd8b2
Status: Passed Duration: 03:11 💡
Started: Feb 29, 2024 11:44 AM Ended: Feb 29, 2024 11:47 AM

Review all test suite changes for PR #7313 ↗︎

@khavinshankar khavinshankar merged commit de5d7ce into develop Feb 29, 2024
64 of 65 checks passed
@khavinshankar khavinshankar deleted the fix-missing-path-params-in-update-preset branch February 29, 2024 11:49
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

Assignees
No one assigned
Labels
P1 breaking issue or vital feature reviewed reviewed by a core member tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rithviknishad @nihal467 @khavinshankar