"Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility #7311

arnit-coder · 2024-02-29T08:06:44Z

Proposed Changes

Fixes "Set average weekly working hour" button in user tab is not responsive #7309
Fixes Facility registration form- cover photo upload #7297
"Set average weekly working hour" in user tab is now responsive.
"Upload cover photo field" added in facility registration form but the backend part is not added. Need to update the backend part also.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

This image is before i corrected the issue, in this image the button "set average weekly working hour is not responsive"
Update product documentation.
Correction of Issue "Set average weekly working hour" button in user tab is not responsive #7309

The button is responsive now.
-[ ] Correction of Issue Facility registration form- cover photo upload #7297

The upload cover photo field
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

vercel · 2024-02-29T08:06:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 29, 2024 10:36am

netlify · 2024-02-29T08:06:59Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`8a25103`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/65e05dde0c390e00086556b0
😎 Deploy Preview	https://deploy-preview-7311--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ility creation.

Ashesh3

LGTM, but fix the lint errors:

npm run lint-fix

Ashesh3 · 2024-03-04T05:36:18Z

src/Components/Facility/FacilityCreate.tsx

+  // const hasPermissionToDeleteFacility =
+  //   authUser.user_type === "DistrictAdmin" ||
+  //   authUser.user_type === "StateAdmin";


Remove the commented code if not needed

Removed sir.

Ashesh3 · 2024-03-04T05:37:11Z

src/Components/Facility/FacilityCreate.tsx

+                          <path d="M18.5 6C18.5 5.4475 18.95 5 19.5 5H20.5C21.05 5 21.5 5.4475 21.5 6V7.5H23C23.55 7.5 24 7.95 24 8.5V9.5C24 10.05 23.55 10.5 23 10.5H21.5V12C21.5 12.55 21.05 13 20.5 13H19.5C18.95 13 18.5 12.55 18.5 12V10.5H17C16.45 10.5 16 10.05 16 9.5V8.5C16 7.95 16.45 7.5 17 7.5H18.5V6ZM25.5 0C27.9875 0 30 2.015 30 4.5V5H35.5C37.9875 5 40 7.0125 40 9.5V27.5C40 29.9875 37.9875 32 35.5 32H4.49875C2.01188 32 0 29.9875 0 27.5V9.5C0 7.0125 2.015 5 4.5 5H10V4.5C10 2.015 12.0125 0 14.5 0H25.5ZM30 8V29H35.5C36.3312 29 37 28.3313 37 27.5V21H33.5C32.6688 21 32 20.3313 32 19.5C32 18.6688 32.6688 18 33.5 18H37V15H33.5C32.6688 15 32 14.3313 32 13.5C32 12.6688 32.6688 12 33.5 12H37V9.5C37 8.66875 36.3312 8 35.5 8H30ZM3 9.5V12H6.5C7.33125 12 8 12.6688 8 13.5C8 14.3313 7.33125 15 6.5 15H3V18H6.5C7.33125 18 8 18.6688 8 19.5C8 20.3313 7.33125 21 6.5 21H3V27.5C3 28.3313 3.67125 29 4.49875 29H10V8H4.5C3.67188 8 3 8.66875 3 9.5ZM13 29H17V25C17 23.3438 18.3438 22 20 22C21.6562 22 23 23.3438 23 25V29H27V4.5C27 3.67188 26.3312 3 25.5 3H14.5C13.6688 3 13 3.67188 13 4.5V29Z" />
+                        </svg>


Use CareIcon component for this icon

Sir, while inserting the CareIcon component i found that a dot is coming when this is inserted

github-actions · 2024-03-04T05:57:44Z

👋 Hi, @arnit-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

rithviknishad · 2024-03-04T06:38:24Z

package.json

@@ -71,6 +72,7 @@
    "echarts-for-react": "^3.0.2",
    "eslint-mdx": "^3.1.5",
    "events": "^3.3.0",
+    "googlemaps": "^1.12.0",


Why was this package added?

rithviknishad · 2024-03-04T06:40:33Z

src/Components/Facility/FacilityCreate.tsx

  const [state, dispatch] = useAutoSaveReducer<FacilityForm>(
    facilityCreateReducer,
    initialState
  );
-  const [isLoading, setIsLoading] = useState(false);
+  const [isLoading1, setIsLoading1] = useState(false);


Give meaningful variable names. One cannot infer what isLoading1 is used for.

rithviknishad · 2024-03-04T06:41:07Z

src/Components/Facility/FacilityCreate.tsx

+    pathParams: {
+      id: facilityId || "",
+    },


set prefetch to false if no facility id is present.

Respected sir,
I have my mid term exams going on.
As soon as I will get time I will work on the requested changes.

github-actions · 2024-03-04T13:39:40Z

👋 Hi, @arnit-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2024-03-12T04:16:36Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions · 2024-03-23T04:15:57Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions · 2024-03-31T04:15:49Z

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

set average button in /users fixed in mobile view

c24d866

arnit-coder requested a review from a team as a code owner February 29, 2024 08:06

vercel bot temporarily deployed to Preview February 29, 2024 08:07 Inactive

added the functionality to upload the cover photo while doing the fac…

8a25103

…ility creation.

vercel bot temporarily deployed to Preview February 29, 2024 10:36 Inactive

arnit-coder changed the title ~~"Set average weekly working hour" button in user tab made responsive~~ "Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility Feb 29, 2024

princepal9120 mentioned this pull request Mar 3, 2024

fix mobile view button (Set average weekly working hour) problem. #7330

Closed

nihal467 requested review from Ashesh3 and rithviknishad March 4, 2024 05:27

Ashesh3 approved these changes Mar 4, 2024

View reviewed changes

Ashesh3 reviewed Mar 4, 2024

View reviewed changes

Ashesh3 mentioned this pull request Mar 4, 2024

"Set average weekly working hour" button in user tab is not responsive. #7331

Closed

github-actions bot added the merge conflict pull requests with merge conflict label Mar 4, 2024

rithviknishad requested changes Mar 4, 2024

View reviewed changes

rithviknishad added changes required and removed merge conflict pull requests with merge conflict labels Mar 4, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Mar 4, 2024

github-actions bot added stale and removed stale labels Mar 12, 2024

github-actions bot added the stale label Mar 23, 2024

github-actions bot closed this Mar 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility #7311

"Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility #7311

arnit-coder commented Feb 29, 2024 •

edited

Loading

vercel bot commented Feb 29, 2024 •

edited

Loading

netlify bot commented Feb 29, 2024 •

edited

Loading

Ashesh3 left a comment

Ashesh3 Mar 4, 2024

arnit-coder Mar 14, 2024

Ashesh3 Mar 4, 2024

arnit-coder Mar 14, 2024

github-actions bot commented Mar 4, 2024

rithviknishad Mar 4, 2024

arnit-coder Mar 14, 2024

rithviknishad Mar 4, 2024

rithviknishad Mar 4, 2024

arnit-coder Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Mar 23, 2024

github-actions bot commented Mar 31, 2024

		<path d="M18.5 6C18.5 5.4475 18.95 5 19.5 5H20.5C21.05 5 21.5 5.4475 21.5 6V7.5H23C23.55 7.5 24 7.95 24 8.5V9.5C24 10.05 23.55 10.5 23 10.5H21.5V12C21.5 12.55 21.05 13 20.5 13H19.5C18.95 13 18.5 12.55 18.5 12V10.5H17C16.45 10.5 16 10.05 16 9.5V8.5C16 7.95 16.45 7.5 17 7.5H18.5V6ZM25.5 0C27.9875 0 30 2.015 30 4.5V5H35.5C37.9875 5 40 7.0125 40 9.5V27.5C40 29.9875 37.9875 32 35.5 32H4.49875C2.01188 32 0 29.9875 0 27.5V9.5C0 7.0125 2.015 5 4.5 5H10V4.5C10 2.015 12.0125 0 14.5 0H25.5ZM30 8V29H35.5C36.3312 29 37 28.3313 37 27.5V21H33.5C32.6688 21 32 20.3313 32 19.5C32 18.6688 32.6688 18 33.5 18H37V15H33.5C32.6688 15 32 14.3313 32 13.5C32 12.6688 32.6688 12 33.5 12H37V9.5C37 8.66875 36.3312 8 35.5 8H30ZM3 9.5V12H6.5C7.33125 12 8 12.6688 8 13.5C8 14.3313 7.33125 15 6.5 15H3V18H6.5C7.33125 18 8 18.6688 8 19.5C8 20.3313 7.33125 21 6.5 21H3V27.5C3 28.3313 3.67125 29 4.49875 29H10V8H4.5C3.67188 8 3 8.66875 3 9.5ZM13 29H17V25C17 23.3438 18.3438 22 20 22C21.6562 22 23 23.3438 23 25V29H27V4.5C27 3.67188 26.3312 3 25.5 3H14.5C13.6688 3 13 3.67188 13 4.5V29Z" />
		</svg>

"Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility #7311

"Set average weekly working hour" button in user tab made responsive and "Facility registration form cover photo upload" added in create facility #7311

Conversation

arnit-coder commented Feb 29, 2024 • edited Loading

Proposed Changes

Merge Checklist

vercel bot commented Feb 29, 2024 • edited Loading

netlify bot commented Feb 29, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

Ashesh3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Mar 23, 2024

github-actions bot commented Mar 31, 2024

arnit-coder commented Feb 29, 2024 •

edited

Loading

vercel bot commented Feb 29, 2024 •

edited

Loading

netlify bot commented Feb 29, 2024 •

edited

Loading