Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve File Preview #7305

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Improve File Preview #7305

merged 3 commits into from
Mar 6, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 28, 2024

This pull request adds a new component called PDFViewer, which allows for rendering and viewing PDF files in the application. The component uses the react-pdf library to handle PDF rendering and provides options for loading and navigating through pages.

image
image
image

Fixes #7240

@Ashesh3 Ashesh3 requested a review from a team as a code owner February 28, 2024 11:39
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 4:23pm

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 04d3cb1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e746bebc4d0b000889a045
😎 Deploy Preview https://deploy-preview-7305--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 28, 2024

Passing run #2205 ↗︎

0 111 0 0 Flakiness 0

Details:

Improve File Preview
Project: CARE Commit: 04d3cb1af1
Status: Passed Duration: 03:20 💡
Started: Mar 5, 2024 4:27 PM Ended: Mar 5, 2024 4:30 PM

Review all test suite changes for PR #7305 ↗︎

@Ashesh3 Ashesh3 changed the title Add PDFViewer component Improve File Preview Feb 28, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@UdaySagar-Git
Copy link
Contributor

Hey @Ashesh3 ,

Does a file preview for CSV and XLSX files already exist? Or is that open for work? I'm currently working on a similar issue, and I would like to implement a file preview for CSV and XLSX files. I just wanted to confirm before starting the work.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Mar 4, 2024

Hey @Ashesh3 ,

Does a file preview for CSV and XLSX files already exist? Or is that open for work? I'm currently working on a similar issue, and I would like to implement a file preview for CSV and XLSX files. I just wanted to confirm before starting the work.

Currently we do not have file preview for CSV and XLSX, you can work on it if you want but remember that we cannot send our document to a third party service to get the render, i.e Google Doc Embed, Office365 embeds won't work for our case, if you can render csv and xlsx files without iframe'ing these third party sites, then sure, take it up!

@UdaySagar-Git
Copy link
Contributor

Hey @Ashesh3 ,
Does a file preview for CSV and XLSX files already exist? Or is that open for work? I'm currently working on a similar issue, and I would like to implement a file preview for CSV and XLSX files. I just wanted to confirm before starting the work.

Currently we do not have file preview for CSV and XLSX, you can work on it if you want but remember that we cannot send our document to a third party service to get the render, i.e Google Doc Embed, Office365 embeds won't work for our case, if you can render csv and xlsx files without iframe'ing these third party sites, then sure, take it up!

I will use the existing packages, read-excel-file and react-csv-reader, for implementation. Is that okay?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Mar 4, 2024

Hey @Ashesh3 ,
Does a file preview for CSV and XLSX files already exist? Or is that open for work? I'm currently working on a similar issue, and I would like to implement a file preview for CSV and XLSX files. I just wanted to confirm before starting the work.

Currently we do not have file preview for CSV and XLSX, you can work on it if you want but remember that we cannot send our document to a third party service to get the render, i.e Google Doc Embed, Office365 embeds won't work for our case, if you can render csv and xlsx files without iframe'ing these third party sites, then sure, take it up!

I will use the existing packages, read-excel-file and react-csv-reader, for implementation. Is that okay?

Yep, that'll be great!

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 5, 2024
@nihal467
Copy link
Member

nihal467 commented Mar 6, 2024

LGTM

@khavinshankar khavinshankar merged commit 7d558ec into develop Mar 6, 2024
61 of 63 checks passed
@khavinshankar khavinshankar deleted the file-preview branch March 6, 2024 17:02
Copy link

github-actions bot commented Mar 6, 2024

@Ashesh3 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance File Preview Experience for Non-Embeddable Documents and PDF Consistency
5 participants