-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log update vital feature modified #7301
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LGTM |
let getLabel = (param: float) => { | ||
let minText = "Low" | ||
let maxText = "High" | ||
switch param { | ||
| 0.0 => (minText, "#059669") | ||
| 5.0 => (maxText, "#DC2626") | ||
| _ => ("", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not have a human-readable values for all the 5 cases like,
0 -> No pain (gray)
1 -> Noticeable (yellow)
2 -> Mild (orange)
3 -> High (light red)
4 -> Extremely high (red)
5 -> Unbearable (darker red)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar should I change it then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please do
cc: @nihal467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened a new pr and done the changes as you described.please review it @khavinshankar
Closing this pr as duplicate |
Proposed Changes
In Log updates (Critical round), Vitals section, there is a section to mark details of pain.
Against a region, user can mark scale of pain from 0-5.
Here the text "Low" , "Normal", "High" comes written next to the number.
Here is the Screenshot of the fix
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist