Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log update vital feature modified #7301

Closed
wants to merge 5 commits into from
Closed

Log update vital feature modified #7301

wants to merge 5 commits into from

Conversation

saloni0419
Copy link
Contributor

@saloni0419 saloni0419 commented Feb 28, 2024

Proposed Changes

In Log updates (Critical round), Vitals section, there is a section to mark details of pain.
Against a region, user can mark scale of pain from 0-5.
Here the text "Low" , "Normal", "High" comes written next to the number.

Here is the Screenshot of the fix
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • removed the appearance of "normal" against 1-4 painscale

@saloni0419 saloni0419 requested a review from a team as a code owner February 28, 2024 09:04
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:09pm

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4242dad
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e751a1e95a7e00087f7c2d
😎 Deploy Preview https://deploy-preview-7301--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saloni0419 saloni0419 changed the title Log update vital feature modified #7290 Log update vital feature modified Feb 28, 2024
@nihal467
Copy link
Member

nihal467 commented Mar 5, 2024

LGTM

Comment on lines +58 to +64
let getLabel = (param: float) => {
let minText = "Low"
let maxText = "High"
switch param {
| 0.0 => (minText, "#059669")
| 5.0 => (maxText, "#DC2626")
| _ => ("", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not have a human-readable values for all the 5 cases like,
0 -> No pain (gray)
1 -> Noticeable (yellow)
2 -> Mild (orange)
3 -> High (light red)
4 -> Extremely high (red)
5 -> Unbearable (darker red)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar should I change it then ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please do

cc: @nihal467

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened a new pr and done the changes as you described.please review it @khavinshankar

@khavinshankar
Copy link
Member

Closing this pr as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log update- vitals
4 participants