-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : Minimum value in forms should be greater than 0 #7273
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@nihal467 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
LGTM |
Co-authored-by: Khavin Shankar <[email protected]>
@Keshav-0907 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a problem with this approach. These checks are valid only if the fields are "required". If no value is entered, the checks should still pass. However, that is not the case with this PR.
Fixed in #7775
cc: @Keshav-0907
Proposed Changes
Screen.Recording.2024-02-26.at.12.19.10.PM.mov
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist