Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Unauthorized Users from Accessing Facility's Patient Registration #7268

Closed
wants to merge 15 commits into from

Conversation

AshrafMd-1
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner February 24, 2024 15:30
Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 3:19pm

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6a6a521
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65da0bac132a3a0008c94a58
😎 Deploy Preview https://deploy-preview-7268--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a36619b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6606a057a95ee600081b7dd2
😎 Deploy Preview https://deploy-preview-7268--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad The way I completed it is if you are a doctor it directly searches for the home facility but the problem is that the facility names are not unique so it may become a problem

One way is directly searching by ID but the backend doesn't have any query related to that

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why would a user who is of type lower than District Admin would want to use "Facility search of home facilities" in the first place when they are going to have only 1 home facility linked to them?

(Correct me if I'm missing something)

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad Yeah that's a good point so

what i will do is

  1. When the user clicks on the Create patient
  2. it directly goes to the patient creation page if the user is below district admin

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can u check once

Copy link

vercel bot commented Mar 18, 2024

@AshrafMd-1 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 19, 2024
Copy link

👋 Hi, @AshrafMd-1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can u check once

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Mar 22, 2024
@AshrafMd-1
Copy link
Contributor Author

There seem to be some errors so I will reopen a new PR

@AshrafMd-1 AshrafMd-1 closed this Mar 29, 2024
@AshrafMd-1 AshrafMd-1 deleted the FIx-#7244 branch March 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants