Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close dropdown when single select option is selected in a multi select dropdown #7253

Merged
merged 17 commits into from
Mar 5, 2024

Conversation

UdaySagar-Git
Copy link
Contributor

Proposed Changes

Before :

image

After :

Screencast.from.23-02-24.04.01.34.AM.IST.webm

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@UdaySagar-Git UdaySagar-Git requested a review from a team as a code owner February 22, 2024 23:03
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 5:38am

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c79442a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e55e3e7d3f2300086a2758
😎 Deploy Preview https://deploy-preview-7253--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @UdaySagar-Git 🚀

Could we make it like

  • When asymptomatic is selected, close the dropdown as the user will not select any more options.
  • But when asymptomatic is unselected, keep the dropdown opened, as the user is expected to continue by selecting one or more symptoms.

@UdaySagar-Git
Copy link
Contributor Author

Screencast.from.23-02-24.11.52.34.AM.IST.webm

@rithviknishad I hope this fixes the issue , let me know if it requires any more changes

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@nihal467
Copy link
Member

@UdaySagar-Git the cypress test is failing, can you fix it

@nihal467 nihal467 added changes required cypress failed pull request with cypress test failure and removed needs testing needs review labels Feb 27, 2024
@UdaySagar-Git
Copy link
Contributor Author

@nihal467
I think "Dummy Facility 40" is not present causing tests to fail
image
Screenshot from 2024-02-28 02-35-59

https://github.com/coronasafe/care_fe/blob/bda15df327003b9bf741edc004fe1eb5d111f463/cypress/e2e/patient_spec/patient_consultation.cy.ts#L22
I ran tests locally by changing "Dummy Facility 40" to "James" and able to pass all the tests
Screenshot from 2024-02-28 02-49-02

@rithviknishad
Copy link
Member

rithviknishad commented Feb 28, 2024

@UdaySagar-Git to run the cypress locally, you'll have to run the backend locally too and load the dummy data onto it. And connect your local FE to the local BE to run cypress

@UdaySagar-Git
Copy link
Contributor Author

@nihal467 can you please help me fix this
image

@nihal467
Copy link
Member

nihal467 commented Mar 3, 2024

@UdaySagar-Git i will look into it, and will let you know by tomorrow EOD

@nihal467
Copy link
Member

nihal467 commented Mar 3, 2024

@UdaySagar-Git the failing test is due to a frontend bug in the staging, upon merging ( #7257 ) tomorrow morning will fix the test

@UdaySagar-Git
Copy link
Contributor Author

@nihal467 sure !

@nihal467 nihal467 added needs testing and removed changes required cypress failed pull request with cypress test failure labels Mar 4, 2024
@nihal467
Copy link
Member

nihal467 commented Mar 5, 2024

LGTM

@khavinshankar khavinshankar merged commit 85e6c88 into ohcnetwork:develop Mar 5, 2024
36 checks passed
Copy link

github-actions bot commented Mar 5, 2024

@UdaySagar-Git Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-close Symptoms dropdown when "ASYMPTOMATIC" selected
5 participants