Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with redirection on login #7237

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fixes issues with redirection on login #7237

merged 3 commits into from
Feb 28, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner February 20, 2024 13:10
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 4:34am

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 58b0991
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65dd660e6f7f240008b6c6ce
😎 Deploy Preview https://deploy-preview-7237--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 20, 2024

Passing run #2164 ↗︎

0 111 0 0 Flakiness 0

Details:

Fixes issues with redirection on login
Project: CARE Commit: 58b09918e6
Status: Passed Duration: 06:26 💡
Started: Feb 27, 2024 4:41 AM Ended: Feb 27, 2024 4:47 AM

Review all test suite changes for PR #7237 ↗︎

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Feb 27, 2024
@khavinshankar khavinshankar merged commit bfa3681 into develop Feb 28, 2024
56 of 63 checks passed
@khavinshankar khavinshankar deleted the fix-redirect branch February 28, 2024 04:13
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect not working upon login
5 participants