Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update log filters on page change #7204

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 11, 2024

Fixes #7203

This pull request fixes the issue with the update log filters not updating correctly when the page changes. The DailyRoundsFilter component now correctly updates the query parameters and triggers a refetch of the data when the filters are applied.

@Ashesh3 Ashesh3 requested a review from a team as a code owner February 11, 2024 20:58
Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 6:03am

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6d19283
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c9b46d2347130007c7078d
😎 Deploy Preview https://deploy-preview-7204--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 11, 2024

Passing run #2074 ↗︎

0 104 0 0 Flakiness 0

Details:

Fix update log filters on page change
Project: CARE Commit: 6d1928330f
Status: Passed Duration: 02:22 💡
Started: Feb 12, 2024 6:06 AM Ended: Feb 12, 2024 6:08 AM

Review all test suite changes for PR #7204 ↗︎

@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fcc276a into develop Feb 12, 2024
62 of 63 checks passed
@khavinshankar khavinshankar deleted the update-log-filter branch February 12, 2024 06:12
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Patient Consultation Page Log Update filter is malfunctioning
4 participants