Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide the diagonses card if it's empty #7196

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix: hide the diagonses card if it's empty #7196

merged 4 commits into from
Feb 14, 2024

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Feb 8, 2024 •
edited
Loading

Bug Fix

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshot

  • Current staging:
    image

  • Fix:
    image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team as a code owner February 8, 2024 13:32
@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 10:07am

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 54fca6f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65cb3f146ce32b00083a6588
😎 Deploy Preview https://deploy-preview-7196--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor nit pick. simplify the chekcs

src/Components/Facility/ConsultationDetails/index.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad requested a review from Ashesh3 February 8, 2024 15:13
@nihal467
Copy link
Member

@aeswibon
image

when there is no diagnosis, there is a 0 being shown in the patient consultation page

@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added reviewed reviewed by a core member and removed needs review labels Feb 13, 2024
@khavinshankar khavinshankar merged commit 847a5de into ohcnetwork:develop Feb 14, 2024
36 checks passed
@github-actions GitHub Actions
Copy link

@aeswibon We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
5 participants
@aeswibon @nihal467 @Ashesh3 @rithviknishad @khavinshankar