-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve resolution images uploaded via camera #7160
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ashesh3 I'm still getting a white image preview for the back camera. The front camera works. (Verified in incognito mode too) |
Oh weird 🤔 . @Omkar76 could you take a look into this issue? |
looking 👀 |
@rithviknishad it's working fine for me 🤔. which browser are you using? |
@rithviknishad its working fine for me as well, try remote debugging to see whats the error. |
Reverted the change applying to facility cover image as per discussion with Nihal - as it increased image load times without adding any extra usability. |
LGTM |
@Omkar76 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Proposed Changes
forceScreenshotSourceSize
to keep original resolution from source video streamscreenshotQuality
set to 1. (default is 0.92)height
andwidth
from as they had no effect. The component height is already limited by the containing modal.Reference https://stackoverflow.com/questions/27420581/get-maximum-video-resolution-with-getusermedia
https://www.npmjs.com/package/react-webcam
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
Screenshots
Images uploaded to this patient http://localhost:4000/facility/a3910fb7-db3d-4ddf-aa39-1f20e61d1453/patient/291bf9c3-b016-43a6-84f3-7ea6d860814c/files/
Before
211 x 376
After
480 x 853