Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters cache restoration logic + cleaner URL query params and filters cache + fixes state management of facility, lsg body and district in patient filters #7157

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Feb 2, 2024

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner February 2, 2024 11:27
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ee381f7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c08ed031afa900086a5771
😎 Deploy Preview https://deploy-preview-7157--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 7:32am

Copy link

cypress bot commented Feb 2, 2024

Passing run #2025 ↗︎

0 102 0 0 Flakiness 0

Details:

Fix filters cache restoration logic and prevent unapplied filters in URL query p...
Project: CARE Commit: ee381f7b49
Status: Passed Duration: 02:36 💡
Started: Feb 5, 2024 7:35 AM Ended: Feb 5, 2024 7:37 AM

Review all test suite changes for PR #7157 ↗︎

@nihal467
Copy link
Member

nihal467 commented Feb 5, 2024

@rithviknishad
image

-> apply a facility filter in the patient advance filter and switch the tab (To assets)
-> After switching back the tab to patient tab
-> Open the advance filter and scroll down to the facility filter column, it is blank even though the filter works well

@rithviknishad
Copy link
Member Author

@nihal467 this is happening in staging too for facility + lsg body + districts too (#7166).

Will fix along with this PR

@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Feb 5, 2024
@rithviknishad rithviknishad changed the title Fix filters cache restoration logic and prevent unapplied filters in URL query params and filters cache Fix filters cache restoration logic + cleaner URL query params and filters cache + fixes state management of facility, lsg body and district in patient filters Feb 5, 2024
@nihal467
Copy link
Member

nihal467 commented Feb 5, 2024

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Feb 5, 2024
@khavinshankar khavinshankar merged commit c08a7f5 into develop Feb 5, 2024
63 of 64 checks passed
@khavinshankar khavinshankar deleted the fix-filters-cache-and-qparams branch February 5, 2024 10:50
Copy link

github-actions bot commented Feb 5, 2024

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature reviewed reviewed by a core member tested
Projects
None yet
4 participants