Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix investigation report pagination when first page is empty #7153

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 2, 2024

This pull request fixes the issue with investigation report pagination when the first page is empty. It removes the unnecessary load more button and displays a loading spinner while the data is being fetched.

  • When loading investigations, if the first set of group (first page), has no results then the app prevents us from loading consecutive pages, even though they may have data.
  • This PR loads the first page WITH data, instead of just the first page.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 8:33am

@Ashesh3 Ashesh3 requested a review from a team as a code owner February 2, 2024 08:33
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0a4e974
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65bca8cc47a8a30008ca0bb9
😎 Deploy Preview https://deploy-preview-7153--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 2, 2024

Passing run #2011 ↗︎

0 102 0 0 Flakiness 0

Details:

Fix investigation report pagination when first page is empty
Project: CARE Commit: 0a4e974187
Status: Passed Duration: 02:37 💡
Started: Feb 2, 2024 8:36 AM Ended: Feb 2, 2024 8:39 AM

Review all test suite changes for PR #7153 ↗︎

@nihal467
Copy link
Member

nihal467 commented Feb 2, 2024

LGTM

@rithviknishad rithviknishad added the reviewed reviewed by a core member label Feb 2, 2024
@khavinshankar khavinshankar merged commit d259c20 into develop Feb 2, 2024
65 of 66 checks passed
@khavinshankar khavinshankar deleted the investigation-pagination-fix branch February 2, 2024 11:16
Copy link

github-actions bot commented Feb 2, 2024

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants