Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update username validation on useradd #7134

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Jan 31, 2024

This pull request updates the username validation on the useradd feature. The changes include:

  • Updating the regular expression pattern for username validation to allow usernames with 4-16 characters.

  • Adding additional validation rules to ensure that usernames only contain lowercase letters, digits, and . _ - characters.

  • Ensuring that usernames start and end with a letter or number.

  • Preventing consecutive special characters . _ - in usernames.

fixes #7115
related but not dependent on ohcnetwork/care#1865

@sainak sainak requested a review from a team as a code owner January 31, 2024 16:37
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 3:49am

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c5475c4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c99509e5e7c00008b249a1
😎 Deploy Preview https://deploy-preview-7134--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 31, 2024

Passing run #2072 ↗︎

0 104 0 0 Flakiness 0

Details:

Update username validation on useradd
Project: CARE Commit: c5475c493e
Status: Passed Duration: 02:40 💡
Started: Feb 12, 2024 3:52 AM Ended: Feb 12, 2024 3:54 AM

Review all test suite changes for PR #7134 ↗︎

Copy link

github-actions bot commented Feb 8, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@nihal467 nihal467 added needs testing urgent P1 breaking issue or vital feature labels Feb 11, 2024
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 12, 2024
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Feb 12, 2024
@khavinshankar khavinshankar merged commit fc8e976 into develop Feb 12, 2024
63 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/username-validate branch February 12, 2024 04:31
Copy link

@sainak We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

username by default lowercase
5 participants