Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show notification when health id registration fails #7114

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

khavinshankar
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@khavinshankar khavinshankar requested a review from a team as a code owner January 29, 2024 04:12
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 1:37pm

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8d78000
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c4d8d3f6813600078ec706
😎 Deploy Preview https://deploy-preview-7114--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 29, 2024

Passing run #2059 ↗︎

0 104 0 0 Flakiness 0

Details:

show notification when health id registration fails
Project: CARE Commit: b63b7e41a3
Status: Passed Duration: 02:32 💡
Started: Feb 8, 2024 11:19 AM Ended: Feb 8, 2024 11:22 AM

Review all test suite changes for PR #7114 ↗︎

@nihal467
Copy link
Member

nihal467 commented Feb 2, 2024

@khavinshankar fix the cypress issue

@nihal467
Copy link
Member

nihal467 commented Feb 8, 2024

LGTM

@nihal467 nihal467 added reviewed reviewed by a core member tested and removed needs review needs testing labels Feb 8, 2024
cypress/e2e/facility_spec/facility_manage.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/facility_spec/facility_manage.cy.ts Outdated Show resolved Hide resolved
@gigincg gigincg merged commit 4fa0533 into develop Feb 8, 2024
25 of 27 checks passed
@gigincg gigincg deleted the show-notification-hf branch February 8, 2024 13:37
Copy link

github-actions bot commented Feb 8, 2024

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants