Whitelist file types in file upload #7044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khavinshankar
added
needs testing
P1
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@aparnacoronasafe In this PR, we have added a whitelist for file types (images, pdfs), other files can't be uploaded. This is done with respect to the Beagel security audit report. Are there any other file types that are used in the field? |
Passing run #1897 ↗︎
Details:
Review all test suite changes for PR #7044 ↗︎ |
|||||||||||||||
|
@khavinshankar mark it for testing once the backend is ready |
rithviknishad
approved these changes
Jan 17, 2024
Ashesh3
approved these changes
Jan 17, 2024
|
LGTM |
nihal467
added
tested
reviewed
gigincg
approved these changes
Jan 17, 2024
|
@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Depends on ohcnetwork/care#1824
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist