Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Cypress Test | Facility Cover Image | Facility Module #7039

Closed
wants to merge 4 commits into from
Closed

New Cypress Test | Facility Cover Image | Facility Module #7039

wants to merge 4 commits into from

Conversation

nihal467
Copy link
Member

Proposed Changes

  • Fixes #issue_number
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nihal467 nihal467 requested a review from a team as a code owner January 15, 2024 17:08
@netlify Netlify
Copy link

netlify bot commented Jan 15, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 670ac21
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a566b463f305000870664c
😎 Deploy Preview https://deploy-preview-7039--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 5:09pm

@nihal467 nihal467 mentioned this pull request Jan 15, 2024
Closed
20 tasks
@cypress Cypress
Copy link

cypress bot commented Jan 15, 2024 •
edited
Loading

Passing run #1885 ↗︎

0 99 0 0 Flakiness 0

Details:

New Cypress Test | Facility Cover Image | Facility Module
Project: CARE Commit: 670ac21cf4
Status: Passed Duration: 03:03 💡
Started: Jan 15, 2024 5:12 PM Ended: Jan 15, 2024 5:15 PM

Review all test suite changes for PR #7039 ↗︎

@github-actions GitHub Actions
Copy link

👋 Hi, @nihal467,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 17, 2024
@nihal467
Copy link
Member Author

Its been combined with #7040 , so closing this PR

@nihal467 nihal467 closed this Jan 17, 2024
@nihal467 nihal467 deleted the faciliy-manage-coverimage branch December 2, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nihal467