Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the variant of the button to show a filter is active #7026

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

shramanpaul
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

filterupdate.mp4

@rithviknishad please have a review

@shramanpaul shramanpaul requested a review from a team as a code owner January 12, 2024 16:17
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:45pm

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f6ab080
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65aea99a715e5100086804a2
😎 Deploy Preview https://deploy-preview-7026--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attempt, but I don't think this looks good and also layout shift happens. The filter button becomes smaller when the filter is applied.

Instead, maybe we could change the Button's variant to "primary" when a filter is present and keep it "secondary" if not.

@shramanpaul
Copy link
Contributor Author

Thanks for the review. I will be making the requested changes as soon as possible

@shramanpaul
Copy link
Contributor Author

shramanpaul commented Jan 18, 2024

filterupdate02.mp4

made the requested changes please have a review @rithviknishad

@shramanpaul shramanpaul changed the title added a small icon to show that a filter is active changed the variant of the button to show a filter is active Jan 18, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner! LGTM

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Jan 22, 2024
@khavinshankar khavinshankar merged commit 154f818 into ohcnetwork:develop Jan 23, 2024
36 checks passed
Copy link

@shramanpaul We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good to merge reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Update - filter
5 participants