Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache only the advance filters #6988

Merged
merged 7 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/Common/hooks/useFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { classNames } from "../../Utils/utils";

export type FilterState = Record<string, unknown>;
export type FilterParamKeys = string | string[];

interface FilterBadgeProps {
name: string;
value?: string;
Expand All @@ -18,7 +19,13 @@ interface FilterBadgeProps {
* A custom hook wrapped around raviger's `useQueryParams` hook to ease handling
* of pagination and filters.
*/
export default function useFilters({ limit = 14 }: { limit?: number }) {
export default function useFilters({
limit = 14,
cacheBlacklist = [],
}: {
limit?: number;
cacheBlacklist?: string[];
}) {
const { t } = useTranslation();
const { kasp_string } = useConfig();
const hasPagination = limit > 0;
Expand All @@ -29,8 +36,14 @@ export default function useFilters({ limit = 14 }: { limit?: number }) {
query: QueryParam,
options?: setQueryParamsOptions
) => {
const updatedQParams = { ...query };

for (const param of cacheBlacklist) {
delete updatedQParams[param];
}

_setQueryParams(query, options);
updateFiltersCache(query);
updateFiltersCache(updatedQParams);
};

const updateQuery = (filter: FilterState) => {
Expand Down
1 change: 1 addition & 0 deletions src/Components/Assets/AssetsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const AssetsList = () => {
resultsPerPage,
} = useFilters({
limit: 18,
cacheBlacklist: ["search"],
});
const [assets, setAssets] = useState([{} as AssetData]);
const [isLoading, setIsLoading] = useState(false);
Expand Down
6 changes: 5 additions & 1 deletion src/Components/ExternalResult/ResultList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import useQuery from "../../Utils/request/useQuery";
import { parsePhoneNumber } from "../../Utils/utils";
import useAuthUser from "../../Common/hooks/useAuthUser";
import { NonReadOnlyUsers } from "../../Utils/AuthorizeFor";

const Loading = lazy(() => import("../Common/Loading"));

export default function ResultList() {
Expand All @@ -29,7 +30,10 @@ export default function ResultList() {
FilterBadges,
advancedFilter,
resultsPerPage,
} = useFilters({ limit: 14 });
} = useFilters({
limit: 14,
cacheBlacklist: ["mobile_number", "name"],
});
const [showDialog, setShowDialog] = useState(false);
const [selectedFacility, setSelectedFacility] = useState<FacilityModel>({
name: "",
Expand Down
1 change: 1 addition & 0 deletions src/Components/Facility/HospitalList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export const HospitalList = () => {
resultsPerPage,
} = useFilters({
limit: 14,
cacheBlacklist: ["search"],
});
let manageFacilities: any = null;
const { user_type } = useAuthUser();
Expand Down
6 changes: 6 additions & 0 deletions src/Components/Patient/ManagePatients.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ export const PatientManager = () => {
resultsPerPage,
} = useFilters({
limit: 12,
cacheBlacklist: [
"name",
"patient_no",
"phone_number",
"emergency_phone_number",
],
});
const [selectedFacility, setSelectedFacility] = useState<FacilityModel>({
name: "",
Expand Down
3 changes: 3 additions & 0 deletions src/Components/Patient/SampleViewAdmin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import CountBlock from "../../CAREUI/display/Count";
import CareIcon from "../../CAREUI/icons/CareIcon";
import { AdvancedFilterButton } from "../../CAREUI/interactive/FiltersSlideover";
import Page from "../Common/components/Page";

const Loading = lazy(() => import("../Common/Loading"));

export default function SampleViewAdmin() {
Expand All @@ -38,6 +39,7 @@ export default function SampleViewAdmin() {
resultsPerPage,
} = useFilters({
limit: 10,
cacheBlacklist: ["patient_name", "district_name"],
});
const dispatch: any = useDispatch();
const initialData: any[] = [];
Expand All @@ -58,6 +60,7 @@ export default function SampleViewAdmin() {
const res = await dispatch(getAnyFacility(qParams.facility));
setFacilityName(res?.data?.name);
}

fetchData();
}, [dispatch, qParams.facility]);

Expand Down
1 change: 1 addition & 0 deletions src/Components/Shifting/BoardView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const ScrollingComponent = withScrolling("div");
export default function BoardView() {
const { qParams, updateQuery, FilterBadges, advancedFilter } = useFilters({
limit: -1,
cacheBlacklist: ["patient_name"],
});
const { wartime_shifting } = useConfig();

Expand Down
2 changes: 1 addition & 1 deletion src/Components/Shifting/ListView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function ListView() {
FilterBadges,
advancedFilter,
resultsPerPage,
} = useFilters({});
} = useFilters({ cacheBlacklist: ["patient_name"] });

const [modalFor, setModalFor] = useState({
externalId: undefined,
Expand Down
5 changes: 4 additions & 1 deletion src/Components/Users/ManageUsers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ export default function ManageUsers() {
FilterBadges,
advancedFilter,
resultsPerPage,
} = useFilters({ limit: 18 });
} = useFilters({
limit: 18,
cacheBlacklist: ["username"],
});
let manageUsers: any = null;
const [expandSkillList, setExpandSkillList] = useState(false);
const [expandFacilityList, setExpandFacilityList] = useState(false);
Expand Down
Loading